|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH 1/6 for-3.0] Update .gitignore |
Date: | Mon, 30 Jul 2018 10:40:41 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/29/2018 04:27 PM, Leonid Bloch wrote:
Adds /roms/vgabios to .gitignore - this directory appears after the build, and was not ignored by Git so far.
Actually, that's the directories for one of the submodules. It seems fishy to have a directory listed in both .gitignore and .gitmodules at the same time, so I'm inclined to NACK this patch, and instead figure out what in the build is dirtying the directory when the submodule is not checked out.
Signed-off-by: Leonid Bloch <address@hidden> --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 5668d02782..2b3b30ae9f 100644 --- a/.gitignore +++ b/.gitignore @@ -212,3 +212,4 @@ trace-dtrace-root.dtrace trace-ust-all.h trace-ust-all.c /target/arm/decode-sve.inc.c +/roms/vgabios
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |