[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] s390x/sclp: fix maxram calculation
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] s390x/sclp: fix maxram calculation |
Date: |
Mon, 30 Jul 2018 17:31:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
Are we still able to get things into 2.12.1 or are we too late?
On 07/30/2018 04:09 PM, Christian Borntraeger wrote:
> We clamp down ram_size to match the sclp increment size. We do
> not do the same for maxram_size, which means for large guests
> with some sizes (e.g. -m 50000) maxram_size differs from ram_size.
> This can break other code (e.g. CMMA migration) which uses maxram_size
> to calculate the number of pages and then throws some errors.
>
> Fixes: 82fab5c5b90e468f3e9d54c ("s390x/sclp: remove memory hotplug support")
> Signed-off-by: Christian Borntraeger <address@hidden>
> CC: address@hidden
> CC: David Hildenbrand <address@hidden>
> ---
> hw/s390x/sclp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
> index bd2a024..4510a80 100644
> --- a/hw/s390x/sclp.c
> +++ b/hw/s390x/sclp.c
> @@ -320,6 +320,7 @@ static void sclp_memory_init(SCLPDevice *sclp)
> initial_mem = initial_mem >> increment_size << increment_size;
>
> machine->ram_size = initial_mem;
> + machine->maxram_size = initial_mem;
> /* let's propagate the changed ram size into the global variable. */
> ram_size = initial_mem;
> }
>
Re: [Qemu-devel] [PATCH 1/1] s390x/sclp: fix maxram calculation,
Christian Borntraeger <=
Re: [Qemu-devel] [PATCH 1/1] s390x/sclp: fix maxram calculation, David Hildenbrand, 2018/07/30
Re: [Qemu-devel] [PATCH 1/1] s390x/sclp: fix maxram calculation, Cornelia Huck, 2018/07/30