[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 03/23] libqtest: Clean up how we read device_del
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 03/23] libqtest: Clean up how we read device_del messages |
Date: |
Fri, 27 Jul 2018 17:13:39 +0200 |
qtest_qmp_device_del() still uses the qmp("") hack to receive a
message, even though we have qmp_receive() since commit 66e0c7b187e.
Put it to use.
Bonus: gets rid of empty format strings. A step towards compile-time
format string checking without triggering -Wformat-zero-length.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
---
tests/libqtest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 9cb4096639..071d7eb7b1 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -1090,7 +1090,7 @@ void qtest_qmp_device_del(const char *id)
g_assert(response1);
g_assert(!qdict_haskey(response1, "error"));
- response2 = qmp("");
+ response2 = qmp_receive();
g_assert(response2);
g_assert(!qdict_haskey(response2, "error"));
--
2.17.1
- [Qemu-devel] [PATCH v2 00/23] tests: Compile-time format string checking for libqtest.h, Markus Armbruster, 2018/07/27
- [Qemu-devel] [PATCH v2 08/23] test-qobject-input-visitor: Avoid format string ambiguity, Markus Armbruster, 2018/07/27
- [Qemu-devel] [PATCH v2 03/23] libqtest: Clean up how we read device_del messages,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 06/23] qobject: New qobject_from_vjsonf_nofail(), qdict_from_vjsonf_nofail(), Markus Armbruster, 2018/07/27
- [Qemu-devel] [PATCH v2 09/23] qobject: qobject_from_jsonv() is dangerous, hide it away, Markus Armbruster, 2018/07/27
- [Qemu-devel] [PATCH v2 22/23] libqtest: Replace qtest_startf() by qtest_initf(), Markus Armbruster, 2018/07/27