[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] qstring: Assert size calculations don't
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] qstring: Assert size calculations don't overflow |
|
Date: |
Fri, 27 Jul 2018 08:18:10 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/27/2018 01:22 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster <address@hidden>
---
qobject/qstring.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
diff --git a/qobject/qstring.c b/qobject/qstring.c
index 18b8eb82f8..1bb7784a88 100644
--- a/qobject/qstring.c
+++ b/qobject/qstring.c
@@ -41,17 +41,19 @@ QString *qstring_from_substr(const char *str, size_t start,
size_t end)
{
QString *qstring;
+ assert(start <= end + 1);
Could also be spelled assert(start < end), but the next patch gets rid
of the +1 so this form is fine.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org