Re: [Qemu-devel] [PATCH 20/25] check: Only test usb-xhci-nec when it is compiled in

[Thomas Huth]

On 07/26/2018 05:09 PM, Juan Quintela wrote:
> Thomas Huth <address@hidden> wrote:
>> On 17.07.2018 13:33, Juan Quintela wrote:
[...]
>>> @@ -347,8 +347,8 @@ check-qtest-ppc64-y += tests/usb-hcd-ohci-test$(EXESUF)
>>>  gcov-files-ppc64-y += hw/usb/hcd-ohci.c
>>>  check-qtest-ppc64-y += tests/usb-hcd-uhci-test$(EXESUF)
>>>  gcov-files-ppc64-y += hw/usb/hcd-uhci.c
>>> -check-qtest-ppc64-y += tests/usb-hcd-xhci-test$(EXESUF)
>>> -gcov-files-ppc64-y += hw/usb/hcd-xhci.c
>>> +check-qtest-ppc64-$(CONFIG_USB_XHCI_NEC) += 
>>> tests/usb-hcd-xhci-test$(EXESUF)
>>> +gcov-files-ppc64-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci.c
>>>  check-qtest-ppc64-y += $(check-qtest-virtio-y)
>>>  check-qtest-ppc64-$(CONFIG_SLIRP) += tests/test-netfilter$(EXESUF)
>>>  check-qtest-ppc64-$(CONFIG_POSIX) += tests/test-filter-mirror$(EXESUF)
>>
>> I wonder whether the gcov lines are still up-to-date, or whether they
>> should include hcd-xhci-nec.c as well? (See commit 0bbb2f3df1ffd9ccf713
>> for the split)
> 
> Added the hcd-xhci-nec.c file to gcov.  I still don't know how to launch
> gcowv :-(  So no clue about how up-to-date the lines are.

See docs/devel/testing.rst - this file contains some explanations.

 Cheers,
  Thomas