Re: [Qemu-devel] [PATCH for-3.1 00/10] Move virtio-ccw devices to separate files

[Cornelia Huck]

On Wed, 25 Jul 2018 19:20:59 +0200
Thomas Huth <address@hidden> wrote:

> On 25.07.2018 15:48, Cornelia Huck wrote:
> > On Wed, 25 Jul 2018 14:20:14 +0200
> > Thomas Huth <address@hidden> wrote:
> >   
> >> For more fine-grained control over the build process, it would be good
> >> to have the possibility to disable single virtio devices, too. We already
> >> have CONFIG_VIRTIO_* switches in the Makefiles, but currently all
> >> virtio-ccw devices are compiled in anyway. Move them to separate files
> >> so we can disable them in the Makefile more easily.
> >>
> >> NB: I did not move virtio-blk-ccw and virtio-net-ccw to a separate file
> >> yet since they are essential for the s390x-virtio machine and thus it
> >> does IMHO not make much sense to disable net and blk. But if somebody
> >> needs that possibility, too, I can add two more patches on top...  
> > 
> > I understand virtio-net-ccw (autogenerated network devices), but why
> > virtio-blk-ccw?  
> 
> Because we set mc->block_default_type = IF_VIRTIO ==> if you disable
> virtio-blk, the CLI options like -hda and -cdrom would not work anymore.

I see. Maybe we need some strategic #ifdefs to deal with this.