[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 22/24] replay: replay BH for IDE trim operati
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v5 22/24] replay: replay BH for IDE trim operation |
Date: |
Wed, 25 Jul 2018 14:29:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 25/07/2018 14:16, Pavel Dovgalyuk wrote:
> This patch makes IDE trim BH deterministic, because it affects
> the device state. Therefore its invocation should be replayed
> instead of running at the random moment.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> ---
> hw/ide/core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/ide/core.c b/hw/ide/core.c
> index 2c62efc..04e22e7 100644
> --- a/hw/ide/core.c
> +++ b/hw/ide/core.c
> @@ -35,6 +35,7 @@
> #include "sysemu/block-backend.h"
> #include "qapi/error.h"
> #include "qemu/cutils.h"
> +#include "sysemu/replay.h"
>
> #include "hw/ide/internal.h"
> #include "trace.h"
> @@ -479,7 +480,7 @@ static void ide_issue_trim_cb(void *opaque, int ret)
> done:
> iocb->aiocb = NULL;
> if (iocb->bh) {
> - qemu_bh_schedule(iocb->bh);
> + replay_bh_schedule_event(iocb->bh);
> }
> }
>
>
>
Reviewed-by: Paolo Bonzini <address@hidden>
- [Qemu-devel] [PATCH v5 13/24] replay: refine replay-time module, (continued)
- [Qemu-devel] [PATCH v5 13/24] replay: refine replay-time module, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 14/24] translator: fix breakpoint processing, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 15/24] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 16/24] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 17/24] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 18/24] replay: describe reverse debugging in docs/replay.txt, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 19/24] replay: allow loading any snapshots before recording, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 20/24] ps2: prevent changing irq state on save and load, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 21/24] replay: wake up vCPU when replaying, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 22/24] replay: replay BH for IDE trim operation, Pavel Dovgalyuk, 2018/07/25
- Re: [Qemu-devel] [PATCH v5 22/24] replay: replay BH for IDE trim operation,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v5 23/24] replay: add BH oneshot event for block layer, Pavel Dovgalyuk, 2018/07/25
- Re: [Qemu-devel] [PATCH v5 23/24] replay: add BH oneshot event for block layer, Alex Bennée, 2018/07/26
- [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers, Pavel Dovgalyuk, 2018/07/25