[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.0 2/4] migration: disallow recovery for re
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH for-3.0 2/4] migration: disallow recovery for release-ram |
Date: |
Tue, 24 Jul 2018 19:39:04 +0800 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Tue, Jul 24, 2018 at 11:21:47AM +0200, Juan Quintela wrote:
> Peter Xu <address@hidden> wrote:
> > Postcopy recovery won't work well with release-ram capability since
> > release-ram will drop the page buffer as long as the page is put into
> > the send buffer. So if there is a network failure happened, any page
> > buffers that have not yet reached the destination VM but have already
> > been sent from the source VM will be lost forever. Let's refuse the
> > client from resuming such a postcopy migration. Luckily release-ram was
> > designed to only be used when src and destination VMs are on the same
> > host, so it should be fine.
> >
> > Signed-off-by: Peter Xu <address@hidden>
>
> Reviewed-by: Juan Quintela <address@hidden>
Thanks.
>
> I wonder if we should have a FAQ somewhere and point an URL to there.
Yeah we possibly should. I have plan to write up a postcopy recovery
wiki page, maybe an addon to the old postcopy wiki page, but I haven't
yet started (especially after knowing that libvirt developers know
well about how to use it already, hence I put that a lower
priority...).
Regards,
--
Peter Xu
Re: [Qemu-devel] [PATCH for-3.0 0/4] migration: some fixes for release-ram, Dr. David Alan Gilbert, 2018/07/24