[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 for 3.0 00/18] docker fixes (and one tcg test
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v3 for 3.0 00/18] docker fixes (and one tcg test tweak) |
Date: |
Tue, 24 Jul 2018 15:57:06 +0800 |
On Mon, Jul 23, 2018 at 6:03 PM Alex Bennée <address@hidden> wrote:
>
>
> Alex Bennée <address@hidden> writes:
>
> > Hi,
> >
> > I've missed the boat for today's rc1 but I'd like to get this merged
> > before rc2. The new docker.py change is technically new functionality
> > but I'm counting it as a usability bug fix as it replaces a random
> > back trace failure with a preemptive failure and message mentioning
> > binfmt_misc configuration. This would have saved Richard a lot of head
> > scratching as he tried to setup a powerpc-user setup to test his
> > setcontext fix (he had a custom binfmt_misc pointing to his src tree).
> >
> > Finally we also drop the runcom test. It was cute that it got
> > resurrected but it is ultimately a pointless test for something I'm
> > sure no one actually uses.
> >
> > There will be a follow-up RFC series after this that cleans-up some of
> > the rough edges when your host is not an x86_64 box but that series
> > won't be targeting the 3.0 release.
> >
> > : The following patches need review
> > : patch docker/disable debian powerpc user cross.patch
> > : patch docker/drop QEMU_TARGET check fallback in EXECUTABLE.patch
> > : patch docker/Update debootstrap script after Debian migrat.patch
> > : patch docker/ignore distro versioning of debootstrap.patch
> > : patch docker/perform basic binfmt_misc validation in docke.patch
> > : patch tests/tcg remove runcom test.patch
>
> Ping?
I had questions about patch 13 and 17. Otherwise looks good.
Maybe you can drop them for now (including patch 9) and send the PULL for
the rest.
I don't know if we can catch up -rc2 but I guess the testing fixes are
fairly safe to sneak in. :)
(My development machine is affected by
an
office power outage, and I was
also
busy with upgrading patchew.org. Sorry for the
late reply
!)
Fam
- [Qemu-devel] [PATCH v3 for 3.0 15/18] docker: add commentary to debian-bootstrap.docker, (continued)
- [Qemu-devel] [PATCH v3 for 3.0 15/18] docker: add commentary to debian-bootstrap.docker, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 16/18] docker: ignore distro versioning of debootstrap, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 17/18] docker: perform basic binfmt_misc validation in docker.py, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 13/18] docker: add --hint to docker.py check, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 14/18] docker: Update debootstrap script after Debian migration from Alioth to Salsa, Alex Bennée, 2018/07/17
- Re: [Qemu-devel] [PATCH v3 for 3.0 00/18] docker fixes (and one tcg test tweak), Alex Bennée, 2018/07/23
- Re: [Qemu-devel] [PATCH v3 for 3.0 00/18] docker fixes (and one tcg test tweak),
Fam Zheng <=