Re: [Qemu-devel] [PATCH v2 2/8] migration: fix counting normal page for compression

[Peter Xu]

On Thu, Jul 19, 2018 at 08:15:14PM +0800, address@hidden wrote:
> From: Xiao Guangrong <address@hidden>
> 
> The compressed page is not normal page
> 
> Signed-off-by: Xiao Guangrong <address@hidden>

I think it'll depend on how we are defining the "normal" page.  AFAIU
it's the count of raw pages, then I think it's correct.

Reviewed-by: Peter Xu <address@hidden>

> ---
>  migration/ram.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/migration/ram.c b/migration/ram.c
> index 0ad234c692..1b016e048d 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -1903,7 +1903,6 @@ retry:
>              qemu_cond_signal(&comp_param[idx].cond);
>              qemu_mutex_unlock(&comp_param[idx].mutex);
>              pages = 1;
> -            ram_counters.normal++;
>              ram_counters.transferred += bytes_xmit;
>              break;
>          }
> -- 
> 2.14.4
> 

Regards,

-- 
Peter Xu