Re: [Qemu-devel] qemu-iotests: workaround to avoid Python3 while running tests on Fedora Docker image

[Daniel P . Berrangé]

On Tue, Jul 17, 2018 at 08:37:58PM -0300, Philippe Mathieu-Daudé wrote:
> I noticed this while running "make address@hidden":
> 
> $ make address@hidden NETWORK=1
>   BUILD   fedora
>     RUN test-block in qemu:fedora
> Configure options:
> --enable-werror --prefix=/tmp/qemu-test/install
> --python=/usr/bin/python3 --target-list=x86_64-softmmu
> ...
> python            /usr/bin/python3 -B
> ...
> 
> 194         - output mismatch (see 194.out.bad)
> --- /tmp/qemu-test/src/tests/qemu-iotests/194.out       2018-07-17
> 22:51:10.000000000 +0000
> +++ /tmp/qemu-test/build/tests/qemu-iotests/194.out.bad 2018-07-17
> 22:58:01.646916625 +0000
> @@ -1,18 +1,18 @@
>  Launching VMs...
>  Launching NBD server on destination...
> -{u'return': {}}
> -{u'return': {}}
> +{'return': {}}
> +{'return': {}}
> 
> and many more errors, until:
> 
> Failures: 045 132 148 152 162 169 194 205 208 218 222
> Failed 11 of 49 tests
> Test failed: iotests raw
> 
> All failures are due to Python2 syntax.
> I started to fix but noticed there are too many and this isn't to
> correct fix for this release.

Were they all due to the unicode string prefix, or where there
difference failures too ?

The unicode string prefix could probably be fixed once by changing
the log() method in iotests.py to have a built-in filter that
chomps the leading 'u'


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|