[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 4/5] riscv_hart: Fix crash when introspecting
From: |
Michael Clark |
Subject: |
Re: [Qemu-devel] [PATCH v1 4/5] riscv_hart: Fix crash when introspecting the device |
Date: |
Wed, 18 Jul 2018 09:04:00 +1200 |
On Wed, Jul 18, 2018 at 8:28 AM, Alistair Francis <address@hidden>
wrote:
> Use the new object_initialize_child() and sysbus_init_child_obj() to
> fix the issue.
>
> Signed-off-by: Alistair Francis <address@hidden>
>
Reviewed-by: Michael Clark <address@hidden>
> ---
> hw/riscv/riscv_hart.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/hw/riscv/riscv_hart.c b/hw/riscv/riscv_hart.c
> index 75ba7ed579..e34a26a0ef 100644
> --- a/hw/riscv/riscv_hart.c
> +++ b/hw/riscv/riscv_hart.c
> @@ -45,11 +45,10 @@ static void riscv_harts_realize(DeviceState *dev,
> Error **errp)
> s->harts = g_new0(RISCVCPU, s->num_harts);
>
> for (n = 0; n < s->num_harts; n++) {
> -
> - object_initialize(&s->harts[n], sizeof(RISCVCPU), s->cpu_type);
> + object_initialize_child(OBJECT(s), "harts[*]", &s->harts[n],
> + sizeof(RISCVCPU), s->cpu_type,
> + &error_abort, NULL);
> s->harts[n].env.mhartid = n;
> - object_property_add_child(OBJECT(s), "harts[*]",
> OBJECT(&s->harts[n]),
> - &error_abort);
> qemu_register_reset(riscv_harts_cpu_reset, &s->harts[n]);
> object_property_set_bool(OBJECT(&s->harts[n]), true,
> "realized", &err);
> --
> 2.17.1
>
>
- [Qemu-devel] [PATCH v1 0/5] riscv: Fix introspection problems, Alistair Francis, 2018/07/17
- [Qemu-devel] [PATCH v1 1/5] sifive_e: Fix crash when introspecting the device, Alistair Francis, 2018/07/17
- [Qemu-devel] [PATCH v1 2/5] sifive_u: Fix crash when introspecting the device, Alistair Francis, 2018/07/17
- [Qemu-devel] [PATCH v1 3/5] virt: Fix crash when introspecting the device, Alistair Francis, 2018/07/17
- [Qemu-devel] [PATCH v1 4/5] riscv_hart: Fix crash when introspecting the device, Alistair Francis, 2018/07/17
- Re: [Qemu-devel] [PATCH v1 4/5] riscv_hart: Fix crash when introspecting the device,
Michael Clark <=
- [Qemu-devel] [PATCH v1 5/5] spike: Fix crash when introspecting the device, Alistair Francis, 2018/07/17
- Re: [Qemu-devel] [PATCH v1 0/5] riscv: Fix introspection problems, Thomas Huth, 2018/07/18
- Re: [Qemu-devel] [PATCH v1 0/5] riscv: Fix introspection problems, Thomas Huth, 2018/07/18