[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 for 3.0 07/18] docker: gracefully skip check_qemu
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PATCH v3 for 3.0 07/18] docker: gracefully skip check_qemu |
Date: |
Tue, 17 Jul 2018 20:55:42 +0100 |
Not all our images are able to run the tests. Rather than use features
we can just check for the existence and run-ability of gtester. If the
image has been setup for binfmt_misc it will be able to run anyway.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
---
v3
- use command -v in preference to bash-ist type
---
tests/docker/common.rc | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index 4ff5974016..4011561587 100755
--- a/tests/docker/common.rc
+++ b/tests/docker/common.rc
@@ -48,7 +48,13 @@ check_qemu()
else
INVOCATION="$@"
fi
- make $MAKEFLAGS $INVOCATION
+
+ if command -v gtester > /dev/null 2>&1 && \
+ gtester --version > /dev/null 2>&1; then
+ make $MAKEFLAGS $INVOCATION
+ else
+ echo "No working gtester, skipping make $INVOCATION"
+ fi
}
test_fail()
--
2.17.1
- [Qemu-devel] [PATCH v3 for 3.0 00/18] docker fixes (and one tcg test tweak), Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 01/18] tests/.gitignore: don't ignore docker tests, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 05/18] docker: split configure_qemu from build_qemu, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 06/18] docker: move make check into check_qemu helper, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 03/18] docker: par down QEMU_CONFIGURE_OPTS in debian-tricore-cross, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 02/18] docker: base debian-tricore on qemu:debian9, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 04/18] docker: fail more gracefully on docker.py check, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 08/18] docker: Makefile.include don't include partial images, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 11/18] docker: add expansion for docker-test-FOO to Makefile.include, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 10/18] docker: add test-unit runner, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 07/18] docker: gracefully skip check_qemu,
Alex Bennée <=
- [Qemu-devel] [PATCH v3 for 3.0 12/18] docker: drop QEMU_TARGET check, fallback in EXECUTABLE not set, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 18/18] tests/tcg: remove runcom test, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 09/18] docker: disable debian-powerpc-user-cross, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 15/18] docker: add commentary to debian-bootstrap.docker, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 16/18] docker: ignore distro versioning of debootstrap, Alex Bennée, 2018/07/17
- [Qemu-devel] [PATCH v3 for 3.0 17/18] docker: perform basic binfmt_misc validation in docker.py, Alex Bennée, 2018/07/17