Re: [Qemu-devel] [PATCH 22/25] check: Only test usb-uhci devices when they are compiled in

[Thomas Huth]

On 17.07.2018 13:33, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  tests/Makefile.include | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 3a78ada070..27f50e3231 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -282,8 +282,8 @@ check-qtest-i386-$(CONFIG_IOH3420) += 
> tests/ioh3420-test$(EXESUF)
>  gcov-files-i386-$(CONFIG_IOH3420) += hw/pci-bridge/ioh3420.c
>  check-qtest-i386-$(CONFIG_USB_OHCI) += tests/usb-hcd-ohci-test$(EXESUF)
>  gcov-files-i386-$(CONFIG_USB_OHCI) += hw/usb/hcd-ohci.c
> -check-qtest-i386-y += tests/usb-hcd-uhci-test$(EXESUF)
> -gcov-files-i386-y += hw/usb/hcd-uhci.c
> +check-qtest-i386-$(CONFIG_USB_UHCI) += tests/usb-hcd-uhci-test$(EXESUF)
> +gcov-files-i386-$(CONFIG_USB_UHCI) += hw/usb/hcd-uhci.c
>  check-qtest-i386-y += tests/usb-hcd-ehci-test$(EXESUF)
>  gcov-files-i386-y += hw/usb/hcd-ehci.c
>  gcov-files-i386-y += hw/usb/dev-hid.c
> @@ -345,8 +345,8 @@ check-qtest-ppc64-y += tests/rtas-test$(EXESUF)
>  check-qtest-ppc64-$(CONFIG_SLIRP) += tests/pxe-test$(EXESUF)
>  check-qtest-ppc64-$(CONFIG_USB_OHCI) += tests/usb-hcd-ohci-test$(EXESUF)
>  gcov-files-ppc64-$(CONFIG_USB_OHCI) += hw/usb/hcd-ohci.c
> -check-qtest-ppc64-y += tests/usb-hcd-uhci-test$(EXESUF)
> -gcov-files-ppc64-y += hw/usb/hcd-uhci.c
> +check-qtest-ppc64-$(CONFIG_USB_UHCI) += tests/usb-hcd-uhci-test$(EXESUF)
> +gcov-files-ppc64-$(CONFIG_USB_UHCI) += hw/usb/hcd-uhci.c
>  check-qtest-ppc64-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF)
>  gcov-files-ppc64-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci.c
>  check-qtest-ppc64-y += $(check-qtest-virtio-y)
> 

Reviewed-by: Thomas Huth <address@hidden>