[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 1/8] i386: Helpers to encode cache informatio
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v8 1/8] i386: Helpers to encode cache information consistently |
|
Date: |
Mon, 16 Jul 2018 16:52:14 -0300 |
|
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Mon, Jul 16, 2018 at 10:20:09AM -0300, Philippe Mathieu-Daudé wrote:
[...]
> > +enum CacheType {
> > + DCACHE,
>
> I just noticed this clashes on mips host:
[...]
> In file included from /usr/include/mips-linux-gnu/sys/cachectl.h:26:0,
> from /tmp/qemu-test/src/tcg/mips/tcg-target.h:202,
> from /tmp/qemu-test/src/include/exec/cpu-defs.h:29,
> from /tmp/qemu-test/src/target/i386/cpu.h:34,
> from /tmp/qemu-test/src/exec.c:23:
> /tmp/qemu-test/src/target/i386/cpu.h:1053:5: error: expected identifier
> before '(' token
> DCACHE,
> ^
Oops. I will take a look and submit a fix. Thanks for the
report!
--
Eduardo