[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.0 1/2] accel/tcg: Use correct test when lo
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH for-3.0 1/2] accel/tcg: Use correct test when looking in victim TLB for code |
|
Date: |
Mon, 16 Jul 2018 08:27:45 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/13/2018 07:16 AM, Peter Maydell wrote:
> @@ -967,7 +967,7 @@ tb_page_addr_t get_page_addr_code(CPUArchState *env,
> target_ulong addr)
> index = (addr >> TARGET_PAGE_BITS) & (CPU_TLB_SIZE - 1);
> mmu_idx = cpu_mmu_index(env, true);
> if (unlikely(!tlb_hit(env->tlb_table[mmu_idx][index].addr_code, addr))) {
> - if (!VICTIM_TLB_HIT(addr_read, addr)) {
> + if (!VICTIM_TLB_HIT(addr_code, addr)) {
Oh geez.
Reviewed-by: Richard Henderson <address@hidden>
r~