[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/16] qom/object: Add a new function object_
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/16] qom/object: Add a new function object_initialize_child() |
Date: |
Mon, 16 Jul 2018 09:05:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 13.07.2018 23:46, Eduardo Habkost wrote:
> On Fri, Jul 13, 2018 at 11:29:17PM +0200, Andreas Färber wrote:
>> Am 13.07.2018 um 23:16 schrieb Eduardo Habkost:
>>> I wonder if we should deprecate object_initialize() and support
>>> only object_initialize_child() later. Initializing an object
>>> contained inside another one without making it a child of the
>>> parent object is a recipe for trouble.
>>
>> The root container object needs to be initialized, too.
>
> If the object is not embedded in another struct, I would expect
> it to be created using object_new() instead of
> object_initialize().
True. So I guess having a closer look at code that calls
object_initialize() only is something for our TODO lists once 3.0 has
been released...
Thomas
[Qemu-devel] [PATCH v2 02/16] hw/core/sysbus: Add a function for creating and attaching an object, Thomas Huth, 2018/07/13
[Qemu-devel] [PATCH v2 03/16] hw/arm/bcm2836: Fix crash with device_add bcm2837 on unsupported machines, Thomas Huth, 2018/07/13
[Qemu-devel] [PATCH v2 04/16] hw/arm/armv7: Fix crash when introspecting the "iotkit" device, Thomas Huth, 2018/07/13