[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 3.0] sm501: Fix warning about unreachable co
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH for 3.0] sm501: Fix warning about unreachable code |
|
Date: |
Sun, 15 Jul 2018 19:19:32 -0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 07/15/2018 05:59 PM, BALATON Zoltan wrote:
> Coverity warned that the false arm of conditional expression is
> unreachable when it is inside an if with the same condition.
> Remove the unreachable code to avoid the warning.
>
> Fixes: CID 1394215
> Reported-by: Paolo Bonzini <address@hidden>
> Signed-off-by: BALATON Zoltan <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/display/sm501.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 9ab29d3..874260a 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -1024,7 +1024,7 @@ static void sm501_i2c_write(void *opaque, hwaddr addr,
> uint64_t value,
> if (res) {
> SM501_DPRINTF("sm501 i2c : transfer failed"
> " i=%d, res=%d\n", i, res);
> - s->i2c_status |= (res ? SM501_I2C_STATUS_ERROR :
> 0);
> + s->i2c_status |= SM501_I2C_STATUS_ERROR;
> return;
> }
> }
>