[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] linux-user: fix mmap_find_vma_reserved()
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v3] linux-user: fix mmap_find_vma_reserved() |
Date: |
Sat, 14 Jul 2018 19:45:25 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/14/2018 02:35 PM, Laurent Vivier wrote:
> The value given by mmap_find_vma_reserved() is used with mmap(),
> so it is needed to be aligned with the host page size.
>
> Since commit 18e80c55bb, reserved_va is only aligned to TARGET_PAGE_SIZE,
> and it works well if this size is greater or equal to the host page size.
>
> But ppc64 hosts have 64kB page size and when we start a 4kiB page size
> guest (like i386), it fails when it tries to mmap the stack:
>
> mmap stack: Invalid argument
>
> Fixes: 18e80c55bb (linux-user: Tidy and enforce reserved_va initialization)
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
>
> Notes:
> v3:
> move initialization of reserved_va to main()
>
> v2:
> fix typo s/has/as/
>
> linux-user/main.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~