[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/5] i386: Add support for IA32_PRED_CMD and
From: |
Robert Hoo |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/5] i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs |
Date: |
Sat, 14 Jul 2018 08:02:59 +0800 |
On Fri, 2018-07-13 at 10:11 -0400, address@hidden wrote:
> (Apologies if this comes out as HTML, using Thunderbird instead of mutt
> here)..
>
> > + uint64_t pred_cmd;
> > + uint64_t arch_capabilities;
>
> Could this be 'arch_cap' ?
>
> >
> > /* End of state preserved by INIT (dummy marker). */
> > struct {} end_init_save;
> > diff --git a/target/i386/kvm.c b/target/i386/kvm.c
> > index 2d174f3..3aab182 100644
> > --- a/target/i386/kvm.c
> > +++ b/target/i386/kvm.c
> > @@ -93,6 +93,8 @@ static bool has_msr_hv_reenlightenment;
> > static bool has_msr_xss;
> > static bool has_msr_spec_ctrl;
> > static bool has_msr_virt_ssbd;
> > +static bool has_msr_pred_cmd;
> > +static bool has_msr_arch_capabilities;
>
> Ditto here?
>
Per Paolo and Eduardo's comments, the 2 fields/variables are gone in new
versions.