[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] iotest: Fix filtering order in 226
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [PATCH] iotest: Fix filtering order in 226 |
|
Date: |
Fri, 13 Jul 2018 16:14:11 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/13/2018 03:41 PM, Max Reitz wrote:
> The test directory should be filtered before the image format, otherwise
> the test will fail if the image format is part of the test directory,
> like so:
>
> [...]
> -can't open: Could not open 'TEST_DIR/t.IMGFMT': Is a directory
> +can't open: Could not open '/tmp/test-IMGFMT/t.IMGFMT': Is a directory
> [...]
>
> Signed-off-by: Max Reitz <address@hidden>
Too many gotchas in our test suite.
Thanks :(
Reviewed-by: John Snow <address@hidden>