|
From: | Juan Quintela |
Subject: | Re: [Qemu-devel] [PATCH 18/20] migration-test: Clean up string interpolation into QMP, part 2 |
Date: | Thu, 12 Jul 2018 13:27:02 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Markus Armbruster <address@hidden> wrote: > Leaving interpolation into JSON to qmp() is more robust than building > QMP input manually, as explained in the recent commit "tests: Clean up > string interpolation into QMP input (simple cases)". > > migrate() interpolates members into a JSON object. Change it to take > its extra QMP arguments as arguments for qdict_from_jsonf_nofail() > instead of a string containing JSON members. > > Bonus: gets rid of a non-literal format string. A step towards > compile-time format string checking without triggering > -Wformat-nonliteral. > > Cc: Juan Quintela <address@hidden> > Cc: Dr. David Alan Gilbert <address@hidden> > Signed-off-by: Markus Armbruster <address@hidden> Reviewed-by: Juan Quintela <address@hidden> Again, much clearen. Thanks.
[Prev in Thread] | Current Thread | [Next in Thread] |