[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] qdev: add HotplugHandler->post_plug() callb
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] qdev: add HotplugHandler->post_plug() callback |
Date: |
Thu, 12 Jul 2018 11:04:19 +0200 |
On Wed, 11 Jul 2018 18:48:21 +0200
Paolo Bonzini <address@hidden> wrote:
> On 11/07/2018 17:22, Igor Mammedov wrote:
> > It also seems wrong to call _plug handler on maybe partially
> > initialized device so perhaps we should first finish devices/children
> > realization then do reset and only after that call _plug() handler
>
> I agree but this is too dangerous until we look at plug() handlers and
I'll put on my TODO list for 3.1
> remove the usage of Error **.
considering we have _per_plug now with all checks, we probably
would be able to remove Error** from _plug but only after splitting/auditing
existing _plug callbacks.
> Introducing a new callback helps the
> transition.
sure, we can drop it later
> Paolo
>
[Qemu-devel] [PATCH 2/2] virtio-scsi: fix hotplug ->reset() vs event race, Stefan Hajnoczi, 2018/07/10
Re: [Qemu-devel] [PATCH 0/2] virtio-scsi: fix hotplug ->reset() vs event race, Fam Zheng, 2018/07/10
Re: [Qemu-devel] [PATCH 0/2] virtio-scsi: fix hotplug ->reset() vs event race, l00284672, 2018/07/10