Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

[Paolo Bonzini]

On 11/07/2018 16:28, Stefan Hajnoczi wrote:
>> + * build_driver_cmd_line(): builds the command line for the driver
>> + * @node. The node name must be a valid qemu identifier, since it
>> + * will be used to build the command line.
>> + *
>> + * It is also possible to pass an optional @args that will be
>> + * concatenated to the command line.
>> + *
>> + * For drivers, prepend -device to the driver name.
>> + */
>> +static void build_driver_cmd_line(QOSGraphNode *node, const char *args)
> Why is this called "driver" instead of "device"?
> 

It's the command line that is needed for the driver to work; it can
include also e.g. a -netdev or -blockdev option, though the most common
case is to have just -device.

>> + *
>> + * QOSGraphObject also provides a destructor, used to deallocate the
>> + * after the test has been executed.
>> + */
>> +struct QOSGraphObject {
>> +    /* for produces, returns void * */
>> +    QOSGetDriver get_driver;
> 
> Unused?
> 
>> +    /* for contains, returns a QOSGraphObject * */
>> +    QOSGetDevice get_device;
> 
> Unused?

What is unused?

Thanks,

Paolo