[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 3.0 10/10] docker: add expansion for docker-
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH for 3.0 10/10] docker: add expansion for docker-test-FOO to Makefile.include |
Date: |
Tue, 10 Jul 2018 22:04:28 +0100 |
User-agent: |
mu4e 1.1.0; emacs 26.1.50 |
Philippe Mathieu-Daudé <address@hidden> writes:
> On 07/09/2018 12:21 PM, Alex Bennée wrote:
>> This allows us to run a particular test on all docker images. For
>> example:
>>
>> make docker-test-unit
>>
>> Will run the unit tests on every supported image.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> ---
>> tests/docker/Makefile.include | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
>> index fe63aacf69..765b2c36f2 100644
>> --- a/tests/docker/Makefile.include
>> +++ b/tests/docker/Makefile.include
>> @@ -152,6 +152,7 @@ $(foreach i,$(filter-out
>> $(DOCKER_PARTIAL_IMAGES),$(DOCKER_IMAGES) $(DOCKER_DEPR
>> ) \
>> $(foreach t,$(DOCKER_TESTS), \
>> $(eval docker-test: address@hidden) \
>> + $(eval docker-$t: address@hidden) \
>> ) \
>> )
>>
>> @@ -162,6 +163,7 @@ docker:
>> @echo
>> @echo ' docker: Print this help.'
>> @echo ' docker-test: Run all image/test combinations.'
>
> Can we rename "docker-test" -> "docker-tests" or is it too late?
Probably, I don't know how many people were actively using it. Fam?
>
>> + @echo ' docker-TEST: Run TEST on all image combinations.'
>> @echo ' docker-clean: Kill and remove residual docker testing
>> containers.'
>> @echo ' address@hidden: Run "TEST" in container "IMAGE".'
>> @echo ' Note: "TEST" is one of the listed test
>> name,'
>>
--
Alex Bennée
- Re: [Qemu-devel] [PATCH for 3.0 01/10] tests/.gitignore: don't ignore docker tests, (continued)
- [Qemu-devel] [PATCH for 3.0 03/10] docker: fail more gracefully on docker.py check, Alex Bennée, 2018/07/09
- [Qemu-devel] [PATCH for 3.0 04/10] docker: split configure_qemu from build_qemu, Alex Bennée, 2018/07/09
- [Qemu-devel] [PATCH for 3.0 07/10] docker: Makefile.include don't include partial images, Alex Bennée, 2018/07/09
- [Qemu-devel] [PATCH for 3.0 06/10] docker: gracefully skip check_qemu, Alex Bennée, 2018/07/09
- [Qemu-devel] [PATCH for 3.0 08/10] docker: disable debian-powerpc-user-cross, Alex Bennée, 2018/07/09
- [Qemu-devel] [PATCH for 3.0 10/10] docker: add expansion for docker-test-FOO to Makefile.include, Alex Bennée, 2018/07/09
[Qemu-devel] [PATCH for 3.0 09/10] docker: add test-unit runner, Alex Bennée, 2018/07/09
Re: [Qemu-devel] [PATCH for 3.0 00/10] various docker fixes, Fam Zheng, 2018/07/10