[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] i386: fix handling of multiboot modules
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] i386: fix handling of multiboot modules |
Date: |
Tue, 10 Jul 2018 14:23:09 -0300 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Tue, Jul 10, 2018 at 08:11:58PM +0300, Roman Kagan wrote:
> On Thu, Jun 07, 2018 at 10:47:47AM +0100, Daniel P. Berrangé wrote:
> > ping...
> >
> > On Mon, May 14, 2018 at 06:19:10PM +0100, Daniel P. Berrangé wrote:
> > > This short series fixes a flaw identified by coverity which broke the
> > > handling of multiboot modules.
> > >
> > > Daniel P. Berrangé (3):
> > > i386: fix regression parsing multiboot initrd modules
> > > i386: only parse the initrd_filename once for multiboot modules
> > > opts: remove redundant check for NULL parameter
> > >
> > > hw/i386/multiboot.c | 35 ++++++++++++++++-------------------
> > > util/qemu-option.c | 8 +++-----
> > > 2 files changed, 19 insertions(+), 24 deletions(-)
> > >
> > > --
> > > 2.17.0
>
> Any reason this hasn't been merged yet?
Lack of reviews, unfortunately. I guess we don't have many
people familiar with the multiboot code.
>
> This fixes a regression that, in particular, makes QEMU segfault when
> running kvm-unit-tests.
As it is a bug fix, I will try to review merge it for the next
rc.
--
Eduardo