[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/33] target/mips: Add emulation of nanoMIPS
From: |
Aleksandar Markovic |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/33] target/mips: Add emulation of nanoMIPS 16-bit load and store instructions |
Date: |
Tue, 10 Jul 2018 12:46:09 +0000 |
> Subject: [PATCH v2 03/33] target/mips: Add emulation of nanoMIPS 16-bit load
> and store > instructions
>
> From: Yongbok Kim <address@hidden>
>
> Add emulation of LWXS16, LB16, SB16, LBU16, LH16, SH16, LHU16, LW16, LWSP16,
> LW4X4, SW4X4, LWGP16, SWSP16, SW16, and SWGP16 instructions.
>
> Signed-off-by: Yongbok Kim <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> Signed-off-by: Stefan Markovic <address@hidden>
> ---
> target/mips/translate.c | 114
> ++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 114 insertions(+)
>
The mixture of using extract32(), NANOMIPS_EXTRACT_XXX(), and mask/shift for
decoding opcodes and registers should be streamlined, as also Richard suggested
in a comment for another patch.
However, this can be fixed later, after the first integration in the upstream,
if the risk of regressions is too high for this stage od development of
nanoMIPS support.
With all these caveats, still:
Reviewed-by: Aleksandar Markovic <address@hidden>
- [Qemu-devel] [PATCH v2 00/33] Add nanoMIPS support to QEMU, Aleksandar Markovic, 2018/07/09
- [Qemu-devel] [PATCH v2 01/33] target/mips: Add nanoMIPS OPCODE table, Aleksandar Markovic, 2018/07/09
- [Qemu-devel] [PATCH v2 02/33] target/mips: Add decode_nanomips_opc() function, Aleksandar Markovic, 2018/07/09
- [Qemu-devel] [PATCH v2 03/33] target/mips: Add emulation of nanoMIPS 16-bit load and store instructions, Aleksandar Markovic, 2018/07/09
- Re: [Qemu-devel] [PATCH v2 03/33] target/mips: Add emulation of nanoMIPS 16-bit load and store instructions,
Aleksandar Markovic <=
- [Qemu-devel] [PATCH v2 04/33] target/mips: Add emulation of nanoMIPS 16-bit logic instructions, Aleksandar Markovic, 2018/07/09
- [Qemu-devel] [PATCH v2 05/33] target/mips: Add emulation of nanoMIPS 16-bit save and restore instructions, Aleksandar Markovic, 2018/07/09
- [Qemu-devel] [PATCH v2 06/33] target/mips: Add emulation of some common nanoMIPS 32-bit instructions, Aleksandar Markovic, 2018/07/09
- [Qemu-devel] [PATCH v2 07/33] target/mips: Add emulation of nanoMIPS 48-bit instructions, Aleksandar Markovic, 2018/07/09
- [Qemu-devel] [PATCH v2 08/33] target/mips: Add emulation of nanoMIPS FP instructions, Aleksandar Markovic, 2018/07/09