qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()
Date: Tue, 10 Jul 2018 07:27:03 -0300
User-agent: Mutt/1.9.2 (2017-12-15)

On Tue, Jul 10, 2018 at 04:15:30PM +0800, Dou Liyang wrote:
[...]
> > > +    if (nb_numa_nodes)
> > >           machine_numa_finish_cpu_init(machine);
> > > -    }
> > missing curly brackets, should look like:
> >         if (nb_numa_nodes) {
> >             machine_numa_finish_cpu_init(machine);
> >         }
> > 
> > with that fixed
> > Reviewed-by: Igor Mammedov <address@hidden>
> > 
> 
> Thank you, Igor.
> 
> Due to Eduardo has sent the pull request of this patch,
> Can I fix this and send v2 patch now?

You can fix this on a follow-up patch and CC qemu-trivial.

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]