Re: [Qemu-devel] [PATCH v2 1/1] tests/migration: Skip tests for ppc tcg

[Thomas Huth]

On 06.07.2018 16:31, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> PPC tcg seems to be failing migration tests quite regularly;
> we believe this is TCG bugs in dirty bit updating; it's
> not clear why PPC fails more but lets skip for the moment.
> 
> $ ./tests/migration-test
> /ppc64/migration/deprecated: OK
> /ppc64/migration/bad_dest: Skipping test: kvm_hv not available OK
> /ppc64/migration/postcopy/unix: Skipping test: kvm_hv not available OK
> /ppc64/migration/precopy/unix: Skipping test: kvm_hv not available OK
> 
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
>  tests/migration-test.c | 23 +++++++++++++++++------
>  1 file changed, 17 insertions(+), 6 deletions(-)
> 
> v2
>   use a print rather than g_test_skip since gtester is broken in
> some version
> 
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index 3a85446f95..331efb0fe5 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -360,7 +360,7 @@ static void migrate_start_postcopy(QTestState *who)
>      qobject_unref(rsp);
>  }
>  
> -static void test_migrate_start(QTestState **from, QTestState **to,
> +static int test_migrate_start(QTestState **from, QTestState **to,
>                                 const char *uri, bool hide_stderr)
>  {
>      gchar *cmd_src, *cmd_dst;
> @@ -385,9 +385,13 @@ static void test_migrate_start(QTestState **from, 
> QTestState **to,
>                                    accel, tmpfs, bootpath, uri);
>      } else if (strcmp(arch, "ppc64") == 0) {
>  
> -        /* On ppc64, the test only works with kvm-hv, but not with kvm-pr */
> +        /* On ppc64, the test only works with kvm-hv, but not with kvm-pr
> +         * and TCG is touchy due to race conditions on dirty bits
> +         * (especially on PPC for some reason)
> +         */
>          if (access("/sys/module/kvm_hv", F_OK)) {
> -            accel = "tcg";
> +            g_print("Skipping test: kvm_hv not available ");
> +            return -1;

That "Skipping test: ..." message is now popping up a couple of times
during "make check-qtest" here on my x86 laptop. That's kind of ugly.
Could you maybe turn that into a g_debug() instead?

 Thomas