[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 7/8] ioapic: remove useless lower bounds check
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 7/8] ioapic: remove useless lower bounds check |
Date: |
Fri, 6 Jul 2018 19:14:27 +0200 |
The vector cannot be negative. Coverity now reports this because it sees an
array access before the check, in ioapic_stat_update_irq.
Reviewed-by: Peter Xu <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/intc/ioapic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
index b393780..b6896ac 100644
--- a/hw/intc/ioapic.c
+++ b/hw/intc/ioapic.c
@@ -152,7 +152,7 @@ static void ioapic_set_irq(void *opaque, int vector, int
level)
if (vector == 0) {
vector = 2;
}
- if (vector >= 0 && vector < IOAPIC_NUM_PINS) {
+ if (vector < IOAPIC_NUM_PINS) {
uint32_t mask = 1 << vector;
uint64_t entry = s->ioredtbl[vector];
--
1.8.3.1
- [Qemu-devel] [PULL 0/8] Bug fixes for 2018-07-06, Paolo Bonzini, 2018/07/06
- [Qemu-devel] [PULL 4/8] i386: fix '-cpu ?' output for host cpu type, Paolo Bonzini, 2018/07/06
- [Qemu-devel] [PULL 1/8] pr-helper: avoid error on PR IN command with zero request size, Paolo Bonzini, 2018/07/06
- [Qemu-devel] [PULL 3/8] qtest: Use cpu address space instead of system memory, Paolo Bonzini, 2018/07/06
- [Qemu-devel] [PULL 2/8] pr-helper: Rework socket path handling, Paolo Bonzini, 2018/07/06
- [Qemu-devel] [PULL 5/8] qemu-char: check errno together with ret < 0, Paolo Bonzini, 2018/07/06
- [Qemu-devel] [PULL 6/8] pr-manager-helper: fix memory leak on event, Paolo Bonzini, 2018/07/06
- [Qemu-devel] [PULL 8/8] checkpatch: handle token pasting better, Paolo Bonzini, 2018/07/06
- [Qemu-devel] [PULL 7/8] ioapic: remove useless lower bounds check,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL 0/8] Bug fixes for 2018-07-06, Peter Maydell, 2018/07/06