[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/8] target/mips: Workaround for checkpatch.p
From: |
Aleksandar Markovic |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/8] target/mips: Workaround for checkpatch.pl hanging on msa_helper.c |
Date: |
Fri, 6 Jul 2018 17:11:04 +0000 |
> I'm not sure it's worth having this but you are the maintainer so your
> choice :)
If someone in future peruses an older version of this file (let's say, while
working on an older version of QEMU), and comes across this problem with
checkpatch.pl, by checking the full history of the file, they would be able to
see what the problem is. Without this patch, they wouldn't.
> What is unclear to me is, while changing this, why only fix
> the suffix and not also the prefix? That is:
>
> uint<space>## BITS ##<space>_t S = _S, T = _T;
It wouldn't be clear what characters caused the problem (or triggered the bug,
if you wish).
Regards,
Aleksandar
- [Qemu-devel] [PATCH v4 0/8] Maintenance and misc fixes and improvements, Aleksandar Markovic, 2018/07/06
- [Qemu-devel] [PATCH v4 5/8] target/mips: Add CP0 BadInstrX register, Aleksandar Markovic, 2018/07/06
- [Qemu-devel] [PATCH v4 1/8] target/mips: Update maintainer's email addresses, Aleksandar Markovic, 2018/07/06
- [Qemu-devel] [PATCH v4 4/8] target/mips: Avoid case statements formulated by ranges, Aleksandar Markovic, 2018/07/06
- [Qemu-devel] [PATCH v4 3/8] target/mips: Update some CP0 registers bit definitions, Aleksandar Markovic, 2018/07/06
- [Qemu-devel] [PATCH v4 8/8] target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0, Aleksandar Markovic, 2018/07/06
- [Qemu-devel] [PATCH v4 7/8] target/mips: Don't update BadVAddr register in Debug Mode, Aleksandar Markovic, 2018/07/06
- [Qemu-devel] [PATCH v4 6/8] target/mips: Amend CP0 WatchHi register implementation, Aleksandar Markovic, 2018/07/06