[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/8] tests/bios-tables-test: Remove useless cast
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 5/8] tests/bios-tables-test: Remove useless casts |
Date: |
Thu, 05 Jul 2018 07:39:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> Patch created mechanically by rerunning:
>
> $ spatch --sp-file scripts/coccinelle/typecast.cocci \
> --macro-file scripts/cocci-macro-file.h \
> --dir . --in-place
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/bios-tables-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> index 4e24930c4b..c1ad1b3470 100644
> --- a/tests/bios-tables-test.c
> +++ b/tests/bios-tables-test.c
> @@ -319,7 +319,7 @@ static bool load_asl(GArray *sdts, AcpiSdtTable *sdt)
> ret = g_spawn_command_line_sync(command_line->str, &out, &out_err, NULL,
> &error);
> g_assert_no_error(error);
> if (ret) {
> - ret = g_file_get_contents(sdt->asl_file, (gchar **)&sdt->asl,
> + ret = g_file_get_contents(sdt->asl_file, &sdt->asl,
> &sdt->asl_len, &error);
> g_assert(ret);
> g_assert_no_error(error);
Reviewed-by: Markus Armbruster <address@hidden>
- Re: [Qemu-devel] [PATCH 2/8] error: Remove NULL checks on error_propagate() calls, (continued)
- [Qemu-devel] [PATCH 3/8] crypto: Remove useless casts, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 4/8] xen: Remove useless casts, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 5/8] tests/bios-tables-test: Remove useless casts, Philippe Mathieu-Daudé, 2018/07/04
- Re: [Qemu-devel] [PATCH 5/8] tests/bios-tables-test: Remove useless casts,
Markus Armbruster <=
- [Qemu-devel] [PATCH 6/8] ui/vnc: Remove useless parenthesis around DIV_ROUND_UP macro, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 8/8] hw/intc/gicv3: Remove useless parenthesis around DIV_ROUND_UP macro, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 7/8] hw/pci-host: Remove useless parenthesis around DIV_ROUND_UP macro, Philippe Mathieu-Daudé, 2018/07/04
- Re: [Qemu-devel] [PATCH 0/8] Coccinelle cleanups, Markus Armbruster, 2018/07/05
- Re: [Qemu-devel] [PATCH 0/8] Coccinelle cleanups, Michael S. Tsirkin, 2018/07/05