[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 07/14] qga-win: Fixing msi upgrade disallow in WiX fi
From: |
Michael Roth |
Subject: |
[Qemu-devel] [PULL 07/14] qga-win: Fixing msi upgrade disallow in WiX file |
Date: |
Tue, 3 Jul 2018 15:52:14 -0500 |
From: Bishara AbuHattoum <address@hidden>
Issue: When upgrading qemu-ga using the msi from an old version
to a newer one, the upgrade is not allowed by the msi
showing this error message "Another version of this product
is already installed."
BZ# 1536331: https://bugzilla.redhat.com/show_bug.cgi?id=1536331
Fix: For the upgrade to be allowed by the msi the WiX file must
provide three things:
1. Changing product's Id. (assigning it to "*")
2. Constant product's UpgradeId. (exists)
3. Changing version. (exists)
Reference:
http://wixtoolset.org/documentation/manual/v3/howtos/updates/major_upgrade.html
Signed-off-by: Bishara AbuHattoum <address@hidden>
Signed-off-by: Michael Roth <address@hidden>
---
qga/installer/qemu-ga.wxs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index 5af11627f8..f751a7e9f7 100644
--- a/qga/installer/qemu-ga.wxs
+++ b/qga/installer/qemu-ga.wxs
@@ -41,7 +41,7 @@
<Product
Name="QEMU guest agent"
- Id="{DF9974AD-E41A-4304-81AD-69AA8F299766}"
+ Id="*"
UpgradeCode="{EB6B8302-C06E-4BEC-ADAC-932C68A3A98D}"
Manufacturer="$(env.QEMU_GA_MANUFACTURER)"
Version="$(env.QEMU_GA_VERSION)"
--
2.11.0
- [Qemu-devel] [PULL 00/14] qga patch queue for soft-freeze, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 02/14] qga: check bytes count read by guest-file-read, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 10/14] qga: bios_supports_mode: decoupling pm-utils and sys logic, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 06/14] qga/schema: fix documentation for GuestOSInfo, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 13/14] qga: systemd hibernate/suspend/hybrid-sleep support, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 04/14] qga-win: add driver path usage to GuestFilesystemInfo, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 09/14] qga: refactoring qmp_guest_suspend_* functions, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 05/14] test-qga: add trivial tests for some commands, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 08/14] qemu-ga: make get-fsinfo work over pci bridges, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 11/14] qga: guest_suspend: decoupling pm-utils and sys logic, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 07/14] qga-win: Fixing msi upgrade disallow in WiX file,
Michael Roth <=
- [Qemu-devel] [PULL 14/14] qga: removing bios_supports_mode, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 01/14] qga: unset frozen state if no mount points are frozen, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 12/14] qga: removing switch statements, adding run_process_child, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 03/14] qga: add mountpoint usage info to GuestFilesystemInfo, Michael Roth, 2018/07/03
- Re: [Qemu-devel] [PULL 00/14] qga patch queue for soft-freeze, Peter Maydell, 2018/07/05