Re: [Qemu-devel] [PATCH v2 03/32] docs/interop/qmp: Improve OOB documentation

[Eric Blake]

On 07/03/2018 03:53 AM, Markus Armbruster wrote:
> OOB documentation is spread over qmp-spec.txt sections 2.2.1
> Capabilities and 2.3 Issuing Commands.  The amount of detail is a bit
> distracting there.  Move the meat of the matter to new section 2.3.1
> Out of band execution.
>
> Throw in a few other improvements while there:
>
> * 2.2 Server Greeting: Drop advice to search entire capabilities
>    array; should be obvious.
>
> * 3. QMP Examples
>
>    - 3.1 Server Greeting: Update greeting to the one we expect for the
>      release.  Now shows capability "oob".  Update qmp-intro.txt
>      likewise.
>
>    - 3.2 Capabilities negotiation: Show client accepting capability
>      "oob".
>
>    - 3.7 Out-of-band execution: New.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---

> +++ b/docs/interop/qmp-intro.txt
> @@ -52,13 +52,14 @@ Escape character is '^]'.
>       "QMP": {
>           "version": {
>               "qemu": {
> -                "micro": 50,
> -                "minor": 6,
> -                "major": 1
> -            },
> -            "package": ""
> -        },
> +                "micro": 0,
> +                "minor": 0 ,

Extra space.

> +                "major": 3
> +            },
> +            "package": "v3.0.0"
> +        },
>           "capabilities": [
> +            "oob"
>           ]
>       }
>   }
R-b stands.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org