[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pulseaudio: process audio data in smaller chunk
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH] pulseaudio: process audio data in smaller chunks |
Date: |
Tue, 3 Jul 2018 11:06:32 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/03/2018 09:19 AM, Gerd Hoffmann wrote:
> The rate of pulseaudio absorbing the audio stream is used to control the
> the rate of the guests audio stream. When the emulated hardware uses
> small chunks (like intel-hda does) we need small chunks on the audio
> backend side too, otherwise that feedback loop doesn't work very well.
>
> Cc: Max Ehrlich <address@hidden>
> Cc: Martin Schrodt <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> audio/paaudio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/audio/paaudio.c b/audio/paaudio.c
> index 949769774d..4c100bc318 100644
> --- a/audio/paaudio.c
> +++ b/audio/paaudio.c
> @@ -227,7 +227,7 @@ static void *qpa_thread_out (void *arg)
> }
> }
>
> - decr = to_mix = audio_MIN (pa->live, pa->g->conf.samples >> 2);
> + decr = to_mix = audio_MIN(pa->live, pa->g->conf.samples >> 5);
> rpos = pa->rpos;
>
> if (audio_pt_unlock(&pa->pt, __func__)) {
> @@ -319,7 +319,7 @@ static void *qpa_thread_in (void *arg)
> }
> }
>
> - incr = to_grab = audio_MIN (pa->dead, pa->g->conf.samples >> 2);
> + incr = to_grab = audio_MIN(pa->dead, pa->g->conf.samples >> 5);
Same pattern/value: can we have a #define?
I looked at the PA intel-hda code and couldn't find the chunk size,
anyway this change looks sane.
> wpos = pa->wpos;
>
> if (audio_pt_unlock(&pa->pt, __func__)) {
>