Re: [Qemu-devel] [PATCH 12/32] qmp: Redo how the client requests out-of-band execution

[Eric Blake]

On 07/02/2018 11:21 AM, Markus Armbruster wrote:
> Commit cf869d53172 "qmp: support out-of-band (oob) execution" added a
> general mechanism for command-independent arguments just for an
> out-of-band flag:
>
>      The "control" key is introduced to store this extra flag.  "control"
>      field is used to store arguments that are shared by all the commands,
>      rather than command specific arguments.  Let "run-oob" be the first.
>
> However, it failed to reject unknown members of "control".  For
> instance, in QMP command
>
>      {"execute": "query-name", "id": 42, "control": {"crap": true}}
>
> "crap" gets silently ignored.
>
> Instead of fixing this, revert the general "control" mechanism
> (because YAGNI), and do it the way I initially proposed, with key
> "exec-oob".  Simpler code, simper interface.
>
> An out-of-band command
>
>      {"execute": "migrate-pause", "id": 42, "control": {"run-oob": true}}
>
> becomes
>
>      {"exec-oob": "migrate-pause", "id": 42}
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

Yay!

> @@ -106,9 +110,6 @@ The format for command execution is:
>     command execution, it is optional and will be part of the response
>     if provided.  The "id" member can be any json-value.  A json-number
>     incremented for each successive command works fine.
> -- The optional "control" member further specifies how the command is
> -  to be executed.  Currently, its only member is optional "run-oob".
> -  See section "2.3.1 Out-of-band execution" for details.

Still could use a mention that 'id' is a VERY good idea when using 
'exec-oob' - but as 7/32 made it optional, you could tweak that part of 
the doc in a later patch when making 'id' required for 'exec-oob'.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org