[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/20] Travis, Code Coverage and Cross Build
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/20] Travis, Code Coverage and Cross Build updates |
Date: |
Mon, 2 Jul 2018 12:20:38 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v3 00/20] Travis, Code Coverage and Cross Build
updates
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
4873e71047 docker: add linux-user powered cross builder for QEMU
34f577cda4 docker: add special rule for deboostrapped images
bbbe49493e docker: add special handling for FROM:debian-%-user targets
3adc2ab166 docker: debian-bootstrap.pre allow customising of variant/url
61cd7bb1f4 docker: drop QEMU build-dep from bootstrap
0024785428 docker: Do not run tests in 'intermediate' images
0f142f6713 docker: Clean the MXE base image
8779053bc8 docker: ubuntu: Use SDL2
305dc1ad2f docker: ubuntu: Update the package list before installing new ones
58bd56936a docker: filter out linux-user builds for mingw
589cc92212 linux-user: add gcov support to preexit_cleanup
57dcf92bea linux-user: introduce preexit_cleanup
f67baf9f57 build-system: add coverage-report target
9d58118bc7 build-system: add clean-coverage target
d750d825dc travis: add gcovr summary for GCOV build
b1fa9ff6d6 docker: add gcovr to travis image
8d87f85bb0 .gitignore: add .gcov files
ce2d745b8d build-system: remove per-test GCOV reporting
87bc2150db travis: test out-of-tree builds
1b44d66f6e travis: do not waste time cloning unused submodules
=== OUTPUT BEGIN ===
Checking PATCH 1/20: travis: do not waste time cloning unused submodules...
Checking PATCH 2/20: travis: test out-of-tree builds...
Checking PATCH 3/20: build-system: remove per-test GCOV reporting...
Checking PATCH 4/20: .gitignore: add .gcov files...
Checking PATCH 5/20: docker: add gcovr to travis image...
Checking PATCH 6/20: travis: add gcovr summary for GCOV build...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#58:
new file mode 100755
total: 0 errors, 1 warnings, 49 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/20: build-system: add clean-coverage target...
Checking PATCH 8/20: build-system: add coverage-report target...
Checking PATCH 9/20: linux-user: introduce preexit_cleanup...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33:
new file mode 100644
total: 0 errors, 1 warnings, 72 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 10/20: linux-user: add gcov support to preexit_cleanup...
ERROR: externs should be avoided in .c files
#27: FILE: linux-user/exit.c:23:
+extern void __gcov_dump(void);
total: 1 errors, 0 warnings, 17 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/20: docker: filter out linux-user builds for mingw...
Checking PATCH 12/20: docker: ubuntu: Update the package list before installing
new ones...
Checking PATCH 13/20: docker: ubuntu: Use SDL2...
Checking PATCH 14/20: docker: Clean the MXE base image...
Checking PATCH 15/20: docker: Do not run tests in 'intermediate' images...
Checking PATCH 16/20: docker: drop QEMU build-dep from bootstrap...
Checking PATCH 17/20: docker: debian-bootstrap.pre allow customising of
variant/url...
Checking PATCH 18/20: docker: add special handling for FROM:debian-%-user
targets...
Checking PATCH 19/20: docker: add special rule for deboostrapped images...
Checking PATCH 20/20: docker: add linux-user powered cross builder for QEMU...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71:
new file mode 100644
total: 0 errors, 1 warnings, 54 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v3 16/20] docker: drop QEMU build-dep from bootstrap, (continued)
- [Qemu-devel] [PATCH v3 16/20] docker: drop QEMU build-dep from bootstrap, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 12/20] docker: ubuntu: Update the package list before installing new ones, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 19/20] docker: add special rule for deboostrapped images, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 17/20] docker: debian-bootstrap.pre allow customising of variant/url, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 15/20] docker: Do not run tests in 'intermediate' images, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 18/20] docker: add special handling for FROM:debian-%-user targets, Alex Bennée, 2018/07/02
- Re: [Qemu-devel] [PATCH v3 00/20] Travis, Code Coverage and Cross Build updates,
no-reply <=