Re: [Qemu-devel] [PATCH 2/2] qapi: Drop qapi-gen --unmask option

[Eric Blake]

On 07/02/2018 01:48 PM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
> > Now that we have useful access to the type name as a comment
> > in the generated qapi-introspect.c, we don't need to regenerate
> > code with a temporary -u option just to get at type names.
> >
> > Signed-off-by: Eric Blake <address@hidden>
>
> I occasionally feed output of query-qmp-schema to ad hoc Python scripts.
> My last one searched for object types containing non-string members
> (directly or indirectly).  -u remains useful there, and having to
> recompile is not a problem.  I'd prefer to keep it.

Would it be any easier to argue for the removal of -u if the generated 
output resembled:

{ "ret-type", QLIT_QSTR("1") /* Foo */ },

that is, sticking in the comment everywhere the type name is mangled to 
an integer, rather than just once per type?

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org