[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 09/20] linux-user: introduce preexit_cleanup
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v3 09/20] linux-user: introduce preexit_cleanup |
Date: |
Mon, 02 Jul 2018 18:59:14 +0100 |
User-agent: |
mu4e 1.1.0; emacs 26.1.50 |
Philippe Mathieu-Daudé <address@hidden> writes:
> On 07/02/2018 01:22 PM, Philippe Mathieu-Daudé wrote:
>> Using:
>>
>> 'configure' '--enable-gprof' '--enable-gcov' '--disable-pie' --static
>> [...]
>> C compiler gcc-8
>> CFLAGS -fprofile-arcs -ftest-coverage -g -g
>> LDFLAGS -Wl,--warn-common -fprofile-arcs -ftest-coverage -m64
>> -static -g
>> gprof enabled yes
>> static build yes
>> PIE no
>> gcov gcov
>> gcov enabled yes
>> docker yes
>>
>> I get:
>>
>> $ make subdir-ppc-linux-user
>> [...]
>> CC ppc-linux-user/linux-user/exit.o
>> linux-user/exit.c: In function ‘preexit_cleanup’:
>> linux-user/exit.c:29:9: error: implicit declaration of function
>> ‘_mcleanup’ [-Werror=implicit-function-declaration]
>> _mcleanup();
>> ^~~~~~~~~
>> linux-user/exit.c:29:9: error: nested extern declaration of ‘_mcleanup’
>> [-Werror=nested-externs]
>> cc1: all warnings being treated as errors
>> make[1]: *** [rules.mak:69: linux-user/exit.o] Error 1
>> make: *** [Makefile:481: subdir-ppc-linux-user] Error 2
>>
>> I suppose gprof and static builds are exclusive.
Yeah I guess this must have always been there because I didn't change
the gprof code, just moved it.
>
> I just noticed we don't have --static builds covered by our continuous
> integration.
> Yet too many matrix cases to cover?
> We could ignore it for 'system' builds, but we should enable it for
> --linux-user which is used by various distributions for with the binfmt
> packages.
Yeah certainly a --disable-system --static build makes sense.
>
> Regards,
>
> Phil.
--
Alex Bennée
- [Qemu-devel] [PATCH v3 05/20] docker: add gcovr to travis image, (continued)
- [Qemu-devel] [PATCH v3 05/20] docker: add gcovr to travis image, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 06/20] travis: add gcovr summary for GCOV build, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 01/20] travis: do not waste time cloning unused submodules, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 07/20] build-system: add clean-coverage target, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 13/20] docker: ubuntu: Use SDL2, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 10/20] linux-user: add gcov support to preexit_cleanup, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 09/20] linux-user: introduce preexit_cleanup, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 14/20] docker: Clean the MXE base image, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 08/20] build-system: add coverage-report target, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 11/20] docker: filter out linux-user builds for mingw, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 20/20] docker: add linux-user powered cross builder for QEMU, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 16/20] docker: drop QEMU build-dep from bootstrap, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 12/20] docker: ubuntu: Update the package list before installing new ones, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 19/20] docker: add special rule for deboostrapped images, Alex Bennée, 2018/07/02