[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/23] target/openrisc improvements
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 00/23] target/openrisc improvements |
|
Date: |
Mon, 2 Jul 2018 07:26:26 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/02/2018 05:01 AM, Stafford Horne wrote:
>> ERROR: spaces required around that '*' (ctx:WxV)
>> #129: FILE: target/openrisc/disas.c:56:
>> + arg_l_##opcode *a, uint32_t insn) \
>> ^
>>
>> ERROR: spaces required around that '*' (ctx:WxV)
>> #224: FILE: target/openrisc/disas.c:151:
>> + arg_lf_##opcode##_##suffix *a, uint32_t insn) \
>> ^
>
> I have fixed these on my branch.
These should not have been "fixed".
This is checkpatch being stupid and not realizing that
the thing on the left is a type and this is a pointer
declaration, not a multiplication.
r~