[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] Fix qemu-system-aarch64 crash
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] Fix qemu-system-aarch64 crash |
Date: |
Mon, 2 Jul 2018 11:46:47 +0100 |
On 30 June 2018 at 01:02, Richard Henderson
<address@hidden> wrote:
> The sequence of events was
> (1) Kernel executed a disabled sve insn,
> (2) Undefined Instruction trap went to EL3,
> (3) Lookup of the exception handler saw el3 and returned asidx 1,
> (4) Which hadn't been set up.
>
> So there's definitely a bug with SVE exception routing.
> That said...
>
> With just the first patch, the kernel goes into a silly exception loop
> which is understandable. With just the second patch, qemu gets SIGABRT
> instead of SIGSEGV, which is definitely easier to debug.
>
> I think I'm in favor of both patches, but you might say we shouldn't
> have to have the first one and just apply the second.
I think my vote is for just the second -- a CPU without the
security extensions should never be emitting transactions
with attrs.secure true, so that's a bug we want to track down.
Suitably placed assert()s do a better job of that than sweeping
the problem under the carpet by squashing the attributes
in arm_asidx_from_attrs().
thanks
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 0/2] Fix qemu-system-aarch64 crash,
Peter Maydell <=