[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ui: do not build-depend or link with libdrm, it
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH] ui: do not build-depend or link with libdrm, it is not needed |
Date: |
Sat, 30 Jun 2018 14:06:27 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/30/2018 01:54 PM, Michael Tokarev wrote:
> Opengl support brings up libdrm. But actually nothing uses this library
> or includes any of its headers. Just remove checking for it from configure.
libgbm is linked to libdrm, but I don't see call from QEMU to libdrm,
son we don't need to check for it (and his headers) indeed.
>
> Signed-off-by: Michael Tokarev <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 65548df1fc..951ff022dd 100755
> --- a/configure
> +++ b/configure
> @@ -3865,7 +3865,7 @@ libs_softmmu="$libs_softmmu $fdt_libs"
> # opengl probe (for sdl2, gtk, milkymist-tmu2)
>
> if test "$opengl" != "no" ; then
> - opengl_pkgs="epoxy libdrm gbm"
> + opengl_pkgs="epoxy gbm"
> if $pkg_config $opengl_pkgs; then
> opengl_cflags="$($pkg_config --cflags $opengl_pkgs)"
> opengl_libs="$($pkg_config --libs $opengl_pkgs)"
>