[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/47] configure: add sanity check to catch builds fr
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 02/47] configure: add sanity check to catch builds from "git archive" |
Date: |
Sat, 30 Jun 2018 08:09:55 +0200 |
From: Daniel P. Berrangé <address@hidden>
The "git archive" feature creates tarballs which are missing all
submodule content. GitHub unhelpfully provides users with "Download"
links that claim to give them valid source release tarballs. These
GitHub archives will not be buildable as they are created by the
"git archive" feature and so are missing content. The user gets
unhelpful messages from make such as:
fatal error: ui/input-keymap-atset1-to-qcode.c: No such file or directory
By adding a sanity check we can give users an informative message about
what they've done wrong.
Signed-off-by: Daniel P. Berrangé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
configure | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/configure b/configure
index ca7de4f..4b489fe 100755
--- a/configure
+++ b/configure
@@ -300,6 +300,24 @@ then
else
git_update=no
git_submodules=""
+
+ if ! test -f "$source_path/ui/keycodemapdb/README"
+ then
+ echo
+ echo "ERROR: missing file $source_path/ui/keycodemapdb/README"
+ echo
+ echo "This is not a GIT checkout but module content appears to"
+ echo "be missing. Do not use 'git archive' or GitHub download links"
+ echo "to acquire QEMU source archives. Non-GIT builds are only"
+ echo "supported with source archives linked from:"
+ echo
+ echo " https://www.qemu.org/download/"
+ echo
+ echo "Developers working with GIT can use scripts/archive-source.sh"
+ echo "if they need to create valid source archives."
+ echo
+ exit 1
+ fi
fi
git="git"
--
1.8.3.1
- [Qemu-devel] [PULL 00/47] More misc patches for 3.0 soft freeze, Paolo Bonzini, 2018/06/30
- [Qemu-devel] [PULL 03/47] include: Add IEC binary prefixes in "qemu/units.h", Paolo Bonzini, 2018/06/30
- [Qemu-devel] [PULL 02/47] configure: add sanity check to catch builds from "git archive",
Paolo Bonzini <=
- [Qemu-devel] [PULL 05/47] x86/cpu: Use definitions from "qemu/units.h", Paolo Bonzini, 2018/06/30
- [Qemu-devel] [PULL 06/47] checkpatch: Recognize IEC binary prefix definitions, Paolo Bonzini, 2018/06/30
- [Qemu-devel] [PULL 04/47] vdi: Use definitions from "qemu/units.h", Paolo Bonzini, 2018/06/30
- [Qemu-devel] [PULL 01/47] i386/kvm: add support for Hyper-V TLB flush, Paolo Bonzini, 2018/06/30
- [Qemu-devel] [PULL 08/47] hw: Directly use "qemu/units.h" instead of "qemu/cutils.h", Paolo Bonzini, 2018/06/30
- [Qemu-devel] [PULL 09/47] hw/ivshmem: Use the IEC binary prefix definitions, Paolo Bonzini, 2018/06/30
- [Qemu-devel] [PULL 07/47] hw: Use IEC binary prefix definitions from "qemu/units.h", Paolo Bonzini, 2018/06/30
- [Qemu-devel] [PULL 10/47] hw/ipack: Use the IEC binary prefix definitions, Paolo Bonzini, 2018/06/30
- [Qemu-devel] [PULL 13/47] hw/xen: Use the IEC binary prefix definitions, Paolo Bonzini, 2018/06/30
- [Qemu-devel] [PULL 12/47] hw/smbios: Use the IEC binary prefix definitions, Paolo Bonzini, 2018/06/30