Re: [Qemu-devel] [PATCH v3 06/20] kvm: arm/arm64: Remove spurious WARN_ON

[Auger Eric]

Hi Suzuki,

On 06/29/2018 01:15 PM, Suzuki K Poulose wrote:
> On a 4-level page table pgd entry can be empty, unlike a 3-level
> page table. Remove the spurious WARN_ON() in stage_get_pud().
> 
> Cc: Marc Zyngier <address@hidden>
> Acked-by: Christoffer Dall <address@hidden>
> Signed-off-by: Suzuki K Poulose <address@hidden>
> ---
>  virt/kvm/arm/mmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c
> index 061e6b3..308171c 100644
> --- a/virt/kvm/arm/mmu.c
> +++ b/virt/kvm/arm/mmu.c
> @@ -976,7 +976,7 @@ static pud_t *stage2_get_pud(struct kvm *kvm, struct 
> kvm_mmu_memory_cache *cache
>       pud_t *pud;
>  
>       pgd = kvm->arch.pgd + stage2_pgd_index(addr);
> -     if (WARN_ON(stage2_pgd_none(*pgd))) {
> +     if (stage2_pgd_none(*pgd)) {
>               if (!cache)
>                       return NULL;
>               pud = mmu_memory_cache_alloc(cache);
> 

Reviewed-by: Eric Auger <address@hidden>

Thanks

Eric