Re: [Qemu-devel] [PATCH 5/6] target/arm: Add ID_ISAR6

[Richard Henderson]

On 06/29/2018 01:40 AM, Peter Maydell wrote:
>>      cpu->id_isar5 = 0x00000000;
>> +    cpu->id_isar6 = 0x00000000;
...
>>      cpu->id_isar5 = 0x00000000;
>> +    cpu->id_isar6 = 0x00000000;
...
>>      cpu->id_isar5 = 0x00000000;
>> +    cpu->id_isar6 = 0x00000000;
...
>>      cpu->id_isar5 = 0x0;
>> +    cpu->id_isar6 = 0x0;
...
> The ARMCPU struct fields should all be initially cleared to
> zero, so you don't really need to explicitly zero-initialize
> isar6 all over the place like this. (Compare isar5, which is
> I think only set in CPUs that are new enough that their TRMs
> mentioned it.)

Actually, the fact that isar5 is explicitly set to 0
in many places is the reason that I initialize isar6.


r~