[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] iotests: add 222 to test basic fleecing
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] iotests: add 222 to test basic fleecing |
Date: |
Thu, 28 Jun 2018 13:10:04 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/28/2018 01:00 PM, John Snow wrote:
Signed-off-by: John Snow <address@hidden>
---
tests/qemu-iotests/222 | 149 +++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/222.out | 60 ++++++++++++++++++
tests/qemu-iotests/group | 1 +
3 files changed, 210 insertions(+)
create mode 100644 tests/qemu-iotests/222
create mode 100644 tests/qemu-iotests/222.out
+
+ log('')
+ log('--- Cleanup ---')
+ log('')
+
+ #log(vm.hmp_qemu_io(srcNode, 'flush'))
+ log(vm.qmp('block-job-cancel', device=srcNode))
Is the commented line still worthwhile to keep?
+ log(vm.qmp('nbd-server-stop'))
+ log(vm.qmp('blockdev-del', node_name=tgtNode))
+ vm.shutdown()
+
+ log('')
+ log('--- Confirming writes ---')
+ log('')
+
+ for p in (overwrite + remainder):
+ cmd = "read -P%s %s %s" % p
+ log(cmd)
+ assert qemu_io_silent(base_img_path, '-c', cmd) == 0
+
Thanks for the additions compared to v1 (including the previously
missing .out file ;)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org