[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/3] qapi/error: converts error_setg(&error_f
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/3] qapi/error: converts error_setg(&error_fatal) to error_report() + exit() |
Date: |
Thu, 28 Jun 2018 14:51:32 +0100 |
On 25 June 2018 at 17:57, Philippe Mathieu-Daudé <address@hidden> wrote:
> Hi,
>
> This series converts error_setg(&error_fatal) to error_report() + exit() as
> suggested by the "qapi/error.h" documentation.
>
> This reduce Coverity and Clang static analyzer positive falses.
>
> See http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg07585.html:
>
> On 07/24/2017 04:52 PM, Eric Blake wrote:
> That's a shame. Rather, we should patch this file (and others) to avoid
> all the inconsistent uses of error_setg(&error_*), to comply with the
> error.h documentation.
>
Applied to target-arm.next, thanks. (Not all arm code, but mostly
close enough that that seems the easiest way to deal with it.)
thanks
-- PMM