Re: [Qemu-devel] [C v2 08/10] hw/m68k: add a dummy SWIM floppy controller

[Laurent Vivier]

Le 28/06/2018 à 10:44, Kevin Wolf a écrit :
> Am 28.06.2018 um 01:23 hat Laurent Vivier geschrieben:
>> Co-developed-by: Mark Cave-Ayland <address@hidden>
>> Signed-off-by: Mark Cave-Ayland <address@hidden>
>> Signed-off-by: Laurent Vivier <address@hidden>
> 
>> +static Property swim_properties[] = {
>> +    DEFINE_PROP_DRIVE("driveA", SWIMCtrl, drives[0].blk),
>> +    DEFINE_PROP_DRIVE("driveB", SWIMCtrl, drives[1].blk),
>> +    DEFINE_PROP_END_OF_LIST(),
>> +};
> 
> This is not the right way to model things. The floppy controller needs
> to expose a bus and floppy drives need to be created with a separate
> -device option.
> 
> isa-fdc still has these options, but that's only for compatibility and
> their implementation is basically a wrapper around the modern qdev way.

Thank you Kevin, I will update this part.

Laurent