qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2] scsi: remove legacy esp_init() function


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 0/2] scsi: remove legacy esp_init() function
Date: Thu, 28 Jun 2018 09:04:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 28/06/2018 07:58, Hervé Poussineau wrote:
> Le 27/06/2018 à 22:01, Mark Cave-Ayland a écrit :
>> On 13/06/18 10:47, Mark Cave-Ayland wrote:
>>
>>> Something else that came out of reviewing Laurent's q800 patchset:
>>> after my
>>> SPARC cleanups last year, MIPS Jazz is the last remaining user of the
>>> legacy
>>> esp_init() function.
>>>
>>> Patch 1 switches mips_jazz_init() over to create the ESP device directly
>>> via qdev. Please note that I do not have any MIPS jazz images and so
>>> this
>>> is compile-tested only (although passes "make check") and needs an
>>> ACK from
>>> someone (Hervé?).
>>>
>>> Now that the last user of esp_init() is gone, patch 2 removes the legacy
>>> function and its associated header.
>>>
>>> Signed-off-by: Mark Cave-Ayland <address@hidden>
>>>
>>>
>>> Mark Cave-Ayland (2):
>>>    hw/mips/jazz: create ESP device directly via qdev
>>>    esp: remove legacy esp_init() function
>>>
>>>   hw/mips/mips_jazz.c   | 19 ++++++++++++++++---
>>>   hw/scsi/esp.c         | 30 ------------------------------
>>>   include/hw/scsi/esp.h |  5 -----
>>>   3 files changed, 16 insertions(+), 38 deletions(-)
>>
>> Ping? Is anyone able to test the MIPS jazz board with these patches at
>> all?
> 
> Tested-by: Hervé Poussineau <address@hidden>
> 
> 

Queued, thanks.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]