Re: [Qemu-devel] [PATCH 4/5] pr-manager: add query-pr-managers QMP command

[Paolo Bonzini]

On 26/06/2018 22:51, Eric Blake wrote:
> On 06/26/2018 10:40 AM, Paolo Bonzini wrote:
>> This command lets you query the connection status of each
>> pr-manager-helper
>> object.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
> 
>> +++ b/qapi/block.json
>> @@ -77,6 +77,33 @@
>>   { 'struct': 'BlockdevSnapshotInternal',
>>     'data': { 'device': 'str', 'name': 'str' } }
>>   +##
>> +# @PRManagerInfo:
>> +#
>> +# Information about a persistent reservation manager
>> +#
>> +# @id: the identifier of the persistent reservation manager
>> +#
>> +# @is-connected: whether the persistent reservation manager is
>> connected to
>> +#                the underlying storage or helper
>> +#
>> +# Since: 3.0
>> +##
>> +{ 'struct': 'PRManagerInfo',
>> +  'data': {'id': 'str', 'is-connected': 'bool'} }
> 
> Bike-shedding: I think 'connected' is a reasonable (and shorter) name
> for this member

Sounds good.

>> +
>> +##
>> +# @query-pr-managers:
>> +#
>> +# Returns a list of information about each persistent reservation
>> manager.
>> +#
>> +# Returns: a list of @PRManagerInfo for each persistent reservation
>> manager
>> +#
>> +# Since: 3.0
>> +##
>> +{ 'command': 'query-pr-managers', 'returns': ['PRManagerInfo'] }
>> +
> 
> As a query command, does it make sense to consider whether this command
> could be provided during preconfig?

Yes, definitely.

Paolo